Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing windows tests #255

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 16, 2024

🦟 Bug fix

Fixes #203

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from nkoenig as a code owner April 16, 2024 22:30
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 16, 2024
@azeey
Copy link
Contributor Author

azeey commented Apr 25, 2024

Failing windows tests have been disabled. CI is still red because of warnings, which should be handled in separate PR.

@azeey azeey changed the title Disable ManagerTest.RunLs test on windows Disable failing windows tests Apr 25, 2024
@azeey
Copy link
Contributor Author

azeey commented May 6, 2024

friendly ping @nkoenig

@azeey azeey merged commit 6459d02 into gazebosim:ign-launch5 May 21, 2024
9 of 10 checks passed
@azeey azeey deleted the diable_manager_ls branch May 21, 2024 22:47
@Blast545 Blast545 mentioned this pull request May 27, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants