Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cmdline tests on homebrew #260

Merged
merged 2 commits into from
May 28, 2024
Merged

Disable cmdline tests on homebrew #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
478aeb5
Disable cmdline tests on homebrew
Blast545 May 27, 2024
03ec85d
Fix import
Blast545 May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ set (gtest_sources
ign_TEST.cc
)

# Disable tests that need CLI on homebrew
if (APPLE)
list(REMOVE_ITEM gtest_sources ign_TEST.cc)
endif()

# Create the library target.
ign_create_core_library(SOURCES ${sources} CXX_STANDARD 17)

Expand Down
6 changes: 4 additions & 2 deletions src/ign_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
#include <ignition/common/Filesystem.hh>
#include "ignition/launch/test_config.hh" // NOLINT(build/include)

#include <ignition/utilities/ExtraTestMacros.hh>

static const std::string kIgnCommand(
std::string("IGN_CONFIG_PATH=") + IGN_CONFIG_PATH + " " +
std::string(BREW_RUBY) + std::string(IGN_PATH) + " launch ");
Expand Down Expand Up @@ -51,7 +53,7 @@ std::string customExecStr(std::string _cmd)
}

/////////////////////////////////////////////////
TEST(CmdLine, Ls)
TEST(CmdLine, IGN_UTILS_TEST_DISABLED_ON_MAC(Ls))
{
std::string cmd = kIgnCommand +
std::string(PROJECT_SOURCE_PATH) + "/test/config/ls.ign";
Expand All @@ -65,7 +67,7 @@ TEST(CmdLine, Ls)
}

/////////////////////////////////////////////////
TEST(CmdLine, EchoSelf)
TEST(CmdLine, IGN_UTILS_TEST_DISABLED_ON_MAC(EchoSelf))
{
std::string filePath =
std::string(PROJECT_SOURCE_PATH) + "/test/config/echo.ign";
Expand Down