-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supress msvc dll exported interface warning #263
Conversation
Signed-off-by: Jorge J. Perez <[email protected]>
@@ -20,7 +20,7 @@ | |||
#include <memory> | |||
#include <string> | |||
|
|||
// #include <ignition/common/SuppressWarning.hh> | |||
#include <ignition/utils/SuppressWarning.hh> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to link against ignition-utils${IGN_UTILS_VER}::core
for this to work. You'd add that in
Line 23 in e2a18dd
${BACKWARD_LIBRARIES} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added it with 7ba196f. But I think the cmd code copies back the Manager.hh source into the cmd folder and then the library is not linked there.
Should I link it there:
gz-launch/src/cmd/CMakeLists.txt
Line 12 in e2a18dd
target_link_libraries(ign PUBLIC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we'll need to link ignition-utils
there as well then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manager.hh seems to be used in various places, I had to add a few extra link includes, CI seems to be happy now.
Signed-off-by: Jorge J. Perez <[email protected]>
Signed-off-by: Jorge J. Perez <[email protected]>
Signed-off-by: Jorge J. Perez <[email protected]>
Signed-off-by: Jorge J. Perez <[email protected]>
Signed-off-by: Jorge J. Perez <[email protected]>
Summary
Suppresses a warning appearing in the CI job for ign-launch5. Reference build: https://build.osrfoundation.org/job/gz_launch-ign-launch5-win/49/
This fix was applied to gz-launch here: https://github.com/gazebosim/gz-launch/pull/199/files#diff-c3f9cb0a10e4084bda0abece3428e80d90754073fc083b78887bfbcf6276bb07
cc: @Crola1702
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.