Fix env parsing by placing it before executable parsing #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <[email protected]>
I think it makes sense, because it is the expected behavior here. |
mjcarroll
added a commit
that referenced
this pull request
Jan 7, 2021
This adds a simple check to verify that the env directives apply to everything in the ignition namespace, as fixed in #81. The test itself is a bit of a workaround. We don't have a mechanism for checking the manager output, and executable command directives cannot expand environment variables. This writes a script that is executed by the test to verify that a file specified by an environment variable is touch-ed Signed-off-by: Michael Carroll <[email protected]>
Merged
This adds a simple check to verify that the env directives apply to everything in the ignition namespace, as fixed in #81. The test itself is a bit of a workaround. We don't have a mechanism for checking the manager output, and executable command directives cannot expand environment variables. This writes a script that is executed by the test to verify that a file specified by an environment variable is touch-ed Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-launch2 #81 +/- ##
===============================================
+ Coverage 29.01% 30.24% +1.22%
===============================================
Files 3 3
Lines 734 734
===============================================
+ Hits 213 222 +9
+ Misses 521 512 -9
Continue to review full report at Codecov.
|
nkoenig
added a commit
that referenced
this pull request
Jan 8, 2021
* Fix env parsing by placing it before executable parsing Signed-off-by: Nate Koenig <[email protected]> * Add tests to #81 (#82) This adds a simple check to verify that the env directives apply to everything in the ignition namespace, as fixed in #81. The test itself is a bit of a workaround. We don't have a mechanism for checking the manager output, and executable command directives cannot expand environment variables. This writes a script that is executed by the test to verify that a file specified by an environment variable is touch-ed Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
nkoenig
added a commit
that referenced
this pull request
Jan 8, 2021
* Fix env parsing by placing it before executable parsing (#81) * Fix env parsing by placing it before executable parsing Signed-off-by: Nate Koenig <[email protected]> * Add tests to #81 (#82) This adds a simple check to verify that the env directives apply to everything in the ignition namespace, as fixed in #81. The test itself is a bit of a workaround. We don't have a mechanism for checking the manager output, and executable command directives cannot expand environment variables. This writes a script that is executed by the test to verify that a file specified by an environment variable is touch-ed Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]> * Prep for 2.2.1 release (#84) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application of environment variables in launch files was broken due to incorrect order of operations. Environment variables need to be set before forking processes. This fixes the problem.
Example:
In the above example, the
GazeboServerwould haveIGN_TRANSPORT_TOPIC_STATISTICS=1butGazeboGuiwould haveIGN_TRANSPORT_TOPIC_STATISTICS = undefined.This is a behavior change from the currently release code, but this fix is fairly important.
Signed-off-by: Nate Koenig [email protected]