Suppress warnings (#444)

* Suppress zero variadic macro args message * Remove unused clang flag, suppress ruby warnings Signed-off-by: Michael Carroll <[email protected]>
gazebosim · Jun 21, 2022 · c4098a7 · c4098a7
1 parent 6bb7586
commit c4098a7
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/src/python_pybind11/src/Filter.hh b/src/python_pybind11/src/Filter.hh
@@ -66,7 +66,7 @@ public:
         PYBIND11_OVERLOAD_PURE(
             const T&,     // Return type (ret_type)
             Filter<T>,    // Parent class (cname)
-            Value         // Name of function in C++ (must match Python name)
+            Value,         // Name of function in C++ (must match Python name)
         );
     }
 };

diff --git a/src/python_pybind11/src/SignalStats.cc b/src/python_pybind11/src/SignalStats.cc
@@ -436,7 +436,7 @@ class SignalRootMeanSquareTrampoline :
             std::string,                      // Return type (ret_type)
             gz::math::SignalStatistic,  // Parent class (cname)
             // Name of function in C++ (must match Python name) (fn)
-            ShortName
+            ShortName,
         );
     }
     // Trampoline (need one for each virtual function)

diff --git a/src/ruby/CMakeLists.txt b/src/ruby/CMakeLists.txt
@@ -53,7 +53,7 @@ if (RUBY_FOUND)
   # Suppress warnings on SWIG-generated files
   target_compile_options(${SWIG_RB_LIB} PRIVATE
     $<$<CXX_COMPILER_ID:GNU>:-Wno-pedantic -Wno-shadow -Wno-maybe-uninitialized -Wno-unused-parameter>
-    $<$<CXX_COMPILER_ID:Clang>:-Wno-shadow -Wno-maybe-uninitialized -Wno-unused-parameter>
+    $<$<CXX_COMPILER_ID:Clang>:-Wno-shadow -Wno-unused-parameter -Wno-deprecated-declarations>
     $<$<CXX_COMPILER_ID:AppleClang>:-Wno-shadow -Wno-maybe-uninitialized -Wno-unused-parameter>
   )
   target_include_directories(${SWIG_RB_LIB} SYSTEM PUBLIC ${RUBY_INCLUDE_DIRS})
@@ -86,7 +86,7 @@ if (RUBY_FOUND)
   foreach (test ${ruby_tests})
     add_test(NAME ${test}.rb COMMAND
       ruby -I${FAKE_INSTALL_PREFIX}/lib/ruby/ignition ${CMAKE_SOURCE_DIR}/src/ruby/${test}.rb
-   	  --gtest_output=xml:${CMAKE_BINARY_DIR}/test_results/${test}rb.xml)
+         --gtest_output=xml:${CMAKE_BINARY_DIR}/test_results/${test}rb.xml)
     set_tests_properties(${test}.rb PROPERTIES
       ENVIRONMENT "${_env_vars}")
   endforeach()

diff --git a/test/integration/deprecated_TEST.cc b/test/integration/deprecated_TEST.cc
@@ -27,6 +27,7 @@
 TEST(Deprecated, IgnitionNamespace)
 {
   ignition::math::Angle angle;
+  (void) angle;
 }
 
 #undef SUPPRESS_IGNITION_HEADER_DEPRECATION