[Issue #71] Update vector2 fuctions from vector3 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pxalcantara <[email protected]>
Signed-off-by: pxalcantara <[email protected]>
Signed-off-by: pxalcantara <[email protected]>
chapulina
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
Thanks for the PR, LGTM! Just note that this is targetting master, so it won't be automatically into Blueprint or Citadel, but we can backport it later.
In the future, you can open PRs like this one against ign-math6. It's ok because adding new functions is backwards-compatible. If you were changing or removing a function, that would need to target master.
|
@chapulina I didn't get, the next PR should I go against |
|
Oh sorry, you can target your PRs to |
chapulina
pushed a commit
that referenced
this pull request
Jul 7, 2020
Signed-off-by: pxalcantara <[email protected]>
Merged
scpeters
pushed a commit
that referenced
this pull request
Jul 13, 2020
Signed-off-by: pxalcantara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some functions to Vector2.hh to make the API more consistent considering the Vector3 behavior, functions added:
These functions intend to start to solve issue #71