-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing include #162
Add missing include #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix, it looks good to me. Do you mind amending your commit and signing it for the DCO check?
Signed-off-by: Tobias Fischer <[email protected]>
8d0cfea
to
c4e1cd0
Compare
Done |
It would be convenient for me to have this fix also in |
Signed-off-by: Tobias Fischer <[email protected]>
I cherry-picked it on #177. It doesn't need to be internal, everyone is welcome to open the backport / forward-port PRs 😉 |
Thanks, good to know! |
Signed-off-by: Tobias Fischer <[email protected]>
See conda-forge/libignition-math4-feedstock#9 which fails without this fix added in conda-forge/libignition-math4-feedstock#10
Also http://www.cplusplus.com/reference/cctype/isspace/
/cc @traversaro