-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Normalized method to Quaternion.hh #169
Add Normalized method to Quaternion.hh #169
Conversation
Signed-off-by: pxalcantara <[email protected]>
Signed-off-by: pxalcantara <[email protected]>
@chapulina @j-rivero Could you help me with this CI error for Windows? I couldn't get the cause 🤔 By the way, Why the unit tests case for Quaternion.hh is so big? Shouldn't we split it into several test cases for each method, in order to be easier to detect the error? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the unit tests case for Quaternion.hh is so big? Shouldn't we split it into several test cases for each method, in order to be easier to detect the error?
I think that's probably just old. I agree that having smaller tests would make it easier to handle regressions whenever we have any.
I couldn't tell what was wrong with the Windows build, so I retriggered it |
Can I make these changes? Should I open an issue for that? |
Yeah go for it! Thanks! |
Just make PR but don't need to open a new issue right? |
Yeah I think that's fine 🆗 |
Signed-off-by: pxalcantara <[email protected]>
Add the method Normalized to the Quaternion class.
This PR is related to #34