Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust style of #180 to match our conventions #181

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Dec 2, 2020

Use {} on separate lines around if statements.

Use {} on separate lines around if statements.

Signed-off-by: Steve Peters <[email protected]>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #181 (c9d2579) into ign-math6 (454e906) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #181   +/-   ##
==========================================
  Coverage      99.19%   99.19%           
==========================================
  Files             61       61           
  Lines           5981     5982    +1     
==========================================
+ Hits            5933     5934    +1     
  Misses            48       48           
Impacted Files Coverage Δ
include/ignition/math/Quaternion.hh 100.00% <ø> (ø)
include/ignition/math/Vector2.hh 100.00% <ø> (ø)
include/ignition/math/Vector3.hh 95.75% <ø> (ø)
include/ignition/math/Vector4.hh 94.44% <ø> (ø)
include/ignition/math/Color.hh 100.00% <100.00%> (ø)
include/ignition/math/Matrix3.hh 100.00% <100.00%> (ø)
include/ignition/math/Matrix4.hh 100.00% <100.00%> (ø)
include/ignition/math/Temperature.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454e906...c9d2579. Read the comment docs.

@scpeters scpeters merged commit e5f264b into ign-math6 Dec 2, 2020
@scpeters scpeters deleted the properly-handle-stream-errors branch December 2, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants