Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up a few SWIG-related warnings #208

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Apr 23, 2021

  • Set policies when relevant
  • Suppress warnings on SWIG-generated files

Signed-off-by: Michael Carroll [email protected]

* Set policies when relevant
* Suppress warnings on SWIG-generated files

Signed-off-by: Michael Carroll <[email protected]>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Apr 23, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, no reason to track those warnings if we can't fix them.

Here's some documentation on CMP0078 as reference.

@chapulina chapulina merged commit 6534dab into ign-math6 Apr 26, 2021
@chapulina chapulina deleted the mjcarroll/warning_cleanup branch April 26, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants