Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to new codecov configuration #209

Merged
merged 2 commits into from
May 3, 2021
Merged

Conversation

j-rivero
Copy link
Contributor

🦟 Bug fix

Summary

The PR changes the codecov management to the one proposed in gazebo-tooling/action-gz-ci#32. Should server as a testing case.

Checklist

  • Signed all commits for DCO

Note to maintainers: Remember to use Squash-Merge

@j-rivero j-rivero requested a review from scpeters as a code owner April 27, 2021 18:23
Signed-off-by: Jose Luis Rivero <[email protected]>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #209 (b3f8f79) into ign-math6 (6b5c704) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #209   +/-   ##
==========================================
  Coverage      99.21%   99.21%           
==========================================
  Files             65       65           
  Lines           6087     6089    +2     
==========================================
+ Hits            6039     6041    +2     
  Misses            48       48           
Impacted Files Coverage Δ
include/ignition/math/Vector2.hh 100.00% <100.00%> (ø)
include/ignition/math/Vector3.hh 95.76% <100.00%> (+0.01%) ⬆️
include/ignition/math/Vector4.hh 94.46% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46928d2...b3f8f79. Read the comment docs.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to sign the commits

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@chapulina chapulina merged commit f6e367f into ign-math6 May 3, 2021
@chapulina chapulina deleted the ign-math6_new_codecov branch May 3, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants