Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SphericalCoordinates Python interface #263

Merged
merged 4 commits into from
Oct 29, 2021
Merged

SphericalCoordinates Python interface #263

merged 4 commits into from
Oct 29, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 11, 2021

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Added SpherialCoordinates Python interface.

It requires #251

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde self-assigned this Oct 11, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Oct 11, 2021
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #263 (cd9aaa3) into ign-math6 (c732c04) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #263   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6374     6374           
==========================================
  Hits            6337     6337           
  Misses            37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c732c04...cd9aaa3. Read the comment docs.

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 29, 2021

friendly ping @scpeters

@ahcorde ahcorde mentioned this pull request Oct 29, 2021
Closed
45 tasks
@scpeters scpeters changed the title Added SphericalCoordinates Python interface SphericalCoordinates Python interface Oct 29, 2021
@scpeters scpeters merged commit 2a6f0ba into ign-math6 Oct 29, 2021
@scpeters scpeters deleted the ahcorde/python/sphericalCoordinates branch October 29, 2021 22:27
kant pushed a commit to kant/ign-math that referenced this pull request Nov 4, 2021
@ahcorde @scpeters @kant
Added SphericalCoordinates Python interface (gazebosim#263)
015d4b7 
Signed-off-by: ahcorde <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Darío Hereñú <[email protected]>
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@azeey azeey Awaiting requested review from azeey

Assignees

@ahcorde ahcorde

Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahcorde @osrf-triage @scpeters @chapulina