Vector2, 3 and 4 with pybind11 #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
github-actions
bot
added
Gazebo 1️1️
|
I made some changes:
|
|
@scpeters or @chapulina this is ready for a initial review. |
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #280 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6359 6359
==========================================
Hits 6337 6337
Misses 22 22
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
8 tasks
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
scpeters
reviewed
Dec 15, 2021
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
scpeters
reviewed
Dec 15, 2021
src/python_pybind11/src/Vector3.hh
Outdated
| "Return the absolute dot product of this vector and " | ||
| "another vector. This is similar to the Dot function, except the " | ||
| "absolute value of each component of the vector is used.") | ||
| .def("abs", &Class::Abs, " Get the absolute value of the vector") |
There was a problem hiding this comment.
nit: leading whitespace in doc-string
Signed-off-by: ahcorde <[email protected]>
scpeters
approved these changes
Dec 16, 2021
scpeters
added a commit
to scpeters/ign-math
that referenced
this pull request
Dec 22, 2021
Ccreated wrappers for Vector2, 3 and 4 with pybind11 Signed-off-by: ahcorde <[email protected]> Co-authored-by: Steve Peters <[email protected]>
scpeters
added a commit
to scpeters/ign-math
that referenced
this pull request
Jan 10, 2022
Ccreated wrappers for Vector2, 3 and 4 with pybind11 Signed-off-by: ahcorde <[email protected]> Co-authored-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this pull request
Jan 10, 2022
Ccreated wrappers for Vector2, 3 and 4 with pybind11 Signed-off-by: ahcorde <[email protected]> Co-authored-by: Steve Peters <[email protected]>
7 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
This is a draft PR tothat create wrappers for Vector2, 3 and 4 with pybind11
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge