Use <ostream> and <istream> narrower includes, not <iostream> #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The use of
<iostream>
induces global constructors in every translation unit to initializestd::cout
andstd::cerr
. We shouldn't do that unless we're actually going to usestd::cout
orstd::cerr
.Reference: https://en.cppreference.com/w/cpp/header/iostream
Checklist
Added tests (N/A)Updated documentation (as needed)Updated migration guide (as needed)codecheck
passed (See contributing) -- no new errors; the 9 errors on themain
branch are also reported on this PR.Note to maintainers: Remember to use Squash-Merge