Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GaussMarkovProcess pybind11 interface and examples #315

Merged
merged 9 commits into from
Dec 28, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 17, 2021

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

This PR creates a GaussMarkovProcess Pybind11 interface and adds examples

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Dec 17, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Dec 17, 2021
Signed-off-by: ahcorde <[email protected]>
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #315 (b3e1a97) into ign-math6 (9085401) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #315   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6360     6360           
==========================================
  Hits            6338     6338           
  Misses            22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9085401...b3e1a97. Read the comment docs.

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Dec 18, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments about the examples

examples/gauss_markov_process_example.py Outdated Show resolved Hide resolved
examples/gauss_markov_process_example.rb Outdated Show resolved Hide resolved
examples/gauss_markov_process_example.rb Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I pushed some tweaks to the examples in b3e1a97

@chapulina chapulina enabled auto-merge (squash) December 28, 2021 16:58
@chapulina chapulina merged commit 7717f49 into ign-math6 Dec 28, 2021
@chapulina chapulina deleted the ahcorde/pybind11/gaussmarkov branch December 28, 2021 17:27
@chapulina chapulina mentioned this pull request Dec 30, 2021
45 tasks
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants