Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor finding pybind11 #360

Merged
merged 13 commits into from
Jan 11, 2022
Merged

Refactor finding pybind11 #360

merged 13 commits into from
Jan 11, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jan 4, 2022

Summary

  • Move find_package call to top-level CMakeLists together with other dependencies
  • Print status messages if found / not found for debugging

The change in src/python_pybind11/CMakeLists.txt is mainly whitespace.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from ahcorde January 4, 2022 23:22
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jan 4, 2022
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #360 (42be2fa) into chapulina/6/focal_dep (075b962) will not change coverage.
The diff coverage is n/a.

❗ Current head 42be2fa differs from pull request most recent head d4bafe6. Consider uploading reports for the commit d4bafe6 to get more accurate results
Impacted file tree graph

@@                  Coverage Diff                   @@
##           chapulina/6/focal_dep     #360   +/-   ##
======================================================
  Coverage                  99.65%   99.65%           
======================================================
  Files                         67       67           
  Lines                       6380     6380           
======================================================
  Hits                        6358     6358           
  Misses                        22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075b962...d4bafe6. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
@j-rivero
Copy link
Contributor

j-rivero commented Jan 5, 2022

I think we have a missing dep in Jenkins, I'm looking into it.

@chapulina
Copy link
Contributor Author

The ign-math6 branch is failing too since we moved to Focal on Jenkins:

https://build.osrfoundation.org/job/ignition_math-ci-ign-math6-focal-amd64/1/console

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

The ign-math6 branch is failing too since we moved to Focal on Jenkins:

This PR should fix it

@chapulina chapulina changed the title Refactor finding pybind11 Refactor finding pybind11 and fix Focal on Jenkins Jan 5, 2022
@chapulina chapulina mentioned this pull request Jan 7, 2022
7 tasks
@chapulina
Copy link
Contributor Author

I broke off the Focal fix into #364 for easier review.

@chapulina chapulina changed the title Refactor finding pybind11 and fix Focal on Jenkins Refactor finding pybind11 Jan 7, 2022
@chapulina chapulina changed the base branch from ign-math6 to chapulina/6/focal_dep January 7, 2022 17:27
Base automatically changed from chapulina/6/focal_dep to ign-math6 January 7, 2022 21:21
@chapulina chapulina merged commit fa67ea8 into ign-math6 Jan 11, 2022
@chapulina chapulina deleted the chapulina/6/pybind11_cmake branch January 11, 2022 18:29
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants