Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute distance between points on a general celestial body #434
Compute distance between points on a general celestial body #434
Changes from 25 commits
1dfaa89
2561aa1
99f2496
4d68400
073d0c2
ecd86e0
d804ebd
d8d5c5c
b401946
03869a9
bc32184
d34ce64
a66fd7b
5f3668c
0a30e5a
723b454
243b673
8a30e07
b1baee5
765b8d9
c487de3
d4ca4c4
9e756fe
2a7c853
571735b
f9a3f07
dd251a2
1fa3f5a
ea26be0
d3b3a1f
e0525a6
b8c4887
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be too nitpicky but if the radius was set in different units then the distance returned would be in those units (eg. radius is in
km
). Not sure if we should mention this, removemeters
in the comment, addin meters
to the comments anywhereradius
is mentioned, or ignore my nitpicky comment? Any thoughts @scpeters ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use meters everywhere in our API, so I think we can just leave it at that