Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport newest appendToStream functions #453

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Part of

Backports the final appendToStream functions after these 2 PRs:

Summary

While creating a Matrix6 class, I thought I'd add it to ign-math6, but with the updates that have been made to Matrix[3|4] on main. One of them requires the use of the appendToStream function, which was added to main in #206 and improved in #376.

I'm not backporting the uses of that function that were introduced in main, because they aren't backwards compatible. I'll use the function in the Matrix6 PR that is coming up next.

Test it

Run the added tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim label Jul 6, 2022
@chapulina chapulina requested review from azeey and jennuine July 6, 2022 02:43
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #453 (5c43624) into ign-math6 (b6f9587) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           ign-math6     #453   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6392     6400    +8     
==========================================
+ Hits            6370     6378    +8     
  Misses            22       22           
Impacted Files Coverage Δ
include/ignition/math/Helpers.hh 98.76% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f9587...5c43624. Read the comment docs.

@chapulina chapulina self-assigned this Jul 6, 2022
@chapulina chapulina mentioned this pull request Jul 6, 2022
9 tasks
@chapulina chapulina merged commit 2b373a5 into ign-math6 Jul 6, 2022
@chapulina chapulina deleted the chapulina/6/appendToStream branch July 6, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11 MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants