Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Windows build in gz-math7 #488

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 26, 2022

🦟 Bug fix

Related to #487

Summary

On windows we need to copy the library instead of using a symlink, this PR should simplify the logic

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from scpeters as a code owner August 26, 2022 11:58
@ahcorde ahcorde self-assigned this Aug 26, 2022
@ahcorde ahcorde linked an issue Aug 26, 2022 that may be closed by this pull request
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 26, 2022
@ahcorde ahcorde requested a review from mjcarroll August 26, 2022 11:58
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #488 (82840ab) into gz-math7 (e9828df) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           gz-math7     #488   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7007     7007           
=========================================
  Hits           6986     6986           
  Misses           21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 95a19b6 into gz-math7 Aug 26, 2022
@mjcarroll mjcarroll deleted the ahcorde/7/fix_windows_build branch August 26, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-math7 not compiling on Windows
2 participants