Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nkoenig/remove ign #542

Closed
wants to merge 3 commits into from
Closed

Nkoenig/remove ign #542

wants to merge 3 commits into from

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 28, 2023

🎉 New feature

Removes ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig marked this pull request as draft July 28, 2023 04:03
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #542 (42f361b) into main (92d6063) will not change coverage.
The diff coverage is n/a.

❗ Current head 42f361b differs from pull request most recent head 39de09d. Consider uploading reports for the commit 39de09d to get more accurate results

@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          77       77           
  Lines        7032     7032           
=======================================
  Hits         7014     7014           
  Misses         18       18           
Files Changed Coverage Δ
include/gz/math/Helpers.hh 100.00% <ø> (ø)

Signed-off-by: Nate Koenig <[email protected]>
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@azeey azeey closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants