Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added box examples in cpp and python #584

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

ms-jagadeeshan
Copy link
Contributor

🎉 New feature

Summary

Added cpp and python example for Box class.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.11%. Comparing base (91c73b9) to head (116dbd9).
Report is 7 commits behind head on gz-math7.

Additional details and impacted files
@@            Coverage Diff            @@
##           gz-math7     #584   +/-   ##
=========================================
  Coverage     94.11%   94.11%           
=========================================
  Files           146      146           
  Lines          9809     9809           
=========================================
  Hits           9232     9232           
  Misses          577      577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please in the cpp code include spaces in all operators and separators <<, =, ,, etc

examples/box_example.cc Outdated Show resolved Hide resolved
examples/box_example.cc Outdated Show resolved Hide resolved
examples/box_example.cc Outdated Show resolved Hide resolved
examples/box_example.cc Outdated Show resolved Hide resolved
examples/box_example.py Outdated Show resolved Hide resolved
examples/box_example.py Outdated Show resolved Hide resolved
examples/box_example.py Outdated Show resolved Hide resolved
examples/box_example.py Outdated Show resolved Hide resolved
Signed-off-by: Jagadeeshan S <[email protected]>
@ms-jagadeeshan
Copy link
Contributor Author

@ahcorde I have did the suggested changes.
Do we have cpplint(CPPLINT.CFG) and clang-tidy(.clang-tidy) config file for gazebo codestyle?
I code in neovim with language servers, formaters, linters enabled, which check for config file in
project root directory, if config file not found, then formats in default way(this mess the formatting), so i turned of my linters and formatters.
We should have linter and formatters config, may be in a gist or in every repo or somewhere else. So it could be downloaded and sym linked locally in project root, and code could be automatically formatted. What do you say?

@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested it works fine.

@arjo129 arjo129 requested a review from ahcorde August 6, 2024 04:33
@arjo129
Copy link
Contributor

arjo129 commented Aug 7, 2024

@ahcorde can we proceed to merge this.

@ahcorde ahcorde enabled auto-merge (squash) August 12, 2024 19:36
@ahcorde ahcorde merged commit 4c7f2c2 into gazebosim:gz-math7 Aug 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants