-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added box examples in cpp and python #584
Conversation
Signed-off-by: Jagadeeshan S <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-math7 #584 +/- ##
=========================================
Coverage 94.11% 94.11%
=========================================
Files 146 146
Lines 9809 9809
=========================================
Hits 9232 9232
Misses 577 577 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please in the cpp code include spaces in all operators and separators <<
, =
, ,
, etc
Signed-off-by: Jagadeeshan S <[email protected]>
@ahcorde I have did the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested it works fine.
@ahcorde can we proceed to merge this. |
🎉 New feature
Summary
Added cpp and python example for Box class.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.