Add bzlmod support for gz-math8 #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeey
added
beta
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/bzlmod
branch
from
54add6c
to
5f3ba37
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
iche033
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
looks good to me, maybe @shameekganguly can take a look as well
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
azeey
reviewed
Oct 18, 2024
| @@ -21,9 +21,8 @@ | |||
| #include <cstring> | |||
| #include <utility> | |||
| #include <gz/math/Helpers.hh> | |||
| #include <gz/math/Vector3.hh> | |||
| #include <gz/math/Quaternion.hh> | |||
There was a problem hiding this comment.
Quaternion is used in this header, so I think we should keep this header. We can probably remove the forward declaration below actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.