-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rule of zero #614
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
I see one compiler warning
|
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey I think this PR created a regression in gz_math8-install_bottle-homebrew-amd64 See log output:
Maybe we're missing a release from gz-utils in homebrew? |
It looks like there's a test in the homebrew formula that builds this with manual compiler flags @scpeters do we actually need this test? I would have thought the CMake test would be sufficient. |
@Crola1702, "fix" in osrf/homebrew-simulation#2723 |
Closes #76
Summary
Most of it was deleting copy constructors, assignment operators and destructors. SignalStats needed a change to make it use
gz::utils::ImplPtr
.Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.