Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eigen/include/ignition headers #624

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Aug 23, 2024

🦟 Bug fix

Split out from #622.

Summary

We forgot to remove the ignition headers from the eigen3 component, so do it now.

I expect the ABI checker job to fail for this PR since the ignition headers are still included on the base branch, but future ABI checks should be able to pass once gz-math8 is fixed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey merged commit 959d255 into gz-math8 Aug 23, 2024
10 of 11 checks passed
@azeey azeey deleted the scpeters/rm_ignition_eigen3 branch August 23, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants