-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'has' functionality in particle Emitter. #137
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-msgs6 #137 +/- ##
==========================================
Coverage 84.59% 84.59%
==========================================
Files 7 7
Lines 818 818
==========================================
Hits 692 692
Misses 126 126 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks API and can't go into a stable release. It needs to be retargeted to main
, and even then, I think we should consider a tick-tock strategy.
The particle emitter was added in the last minor release. I'm making this change in a subsequent minor release. The impact is minimal and is needed by subt. |
Ok, let's make this exception since there are probably no users of particles yet and the release is still fresh. In the future, we should consider making pre-releases for new features that are still under development. We need to time well the next Can you add a note about the ABI break to the migration guide? |
Signed-off-by: Nate Koenig <[email protected]>
Added in ef3e3f4 |
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig [email protected]
🦟 Bug fix
Summary
The particle emitter message used plain data types. This prevents an Ignition system from knowing if a value has been set. Since we are using the emitter message as the
Component
in Ignition, we need this information.I'm changing the message types. Since this message was just introduced the impact should be minimal.
Required by: gazebosim/gz-sim#651
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge