Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 8 -> main #236

Merged
merged 16 commits into from
Mar 18, 2022
Merged

Merge 8 -> main #236

merged 16 commits into from
Mar 18, 2022

Conversation

scpeters
Copy link
Member

➡️ Forward port

Port ign-msgs8 to main

Branch comparison: main...ign-msgs8

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #236 (85db26d) into main (12b1593) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files           9        9           
  Lines         956      956           
=======================================
  Hits          817      817           
  Misses        139      139           
Impacted Files Coverage Δ
include/ignition/msgs/PointCloudPackedUtils.hh 84.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b1593...85db26d. Read the comment docs.

@chapulina chapulina changed the base branch from ign-msgs8 to main March 18, 2022 18:05
@chapulina chapulina added 🌱 garden Ignition Garden and removed 🏯 fortress Ignition Fortress labels Mar 18, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with happy CI.

The ABI checker can be disregarded, it was triggered because the PR originally targeted a release branch.

@scpeters scpeters merged commit 64dc7b6 into main Mar 18, 2022
@scpeters scpeters deleted the merge8main branch March 18, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants