Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Migrate Ignition Headers : gz-plugin #101

Merged
merged 4 commits into from
Nov 11, 2022

Conversation

methylDragon
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #101 (6943301) into ign-plugin1 (0575eda) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 6943301 differs from pull request most recent head 507e2cb. Consider uploading reports for the commit 507e2cb to get more accurate results

@@             Coverage Diff              @@
##           ign-plugin1     #101   +/-   ##
============================================
  Coverage        99.82%   99.82%           
============================================
  Files               15       15           
  Lines              584      584           
============================================
  Hits               583      583           
  Misses               1        1           
Impacted Files Coverage Δ
core/include/gz/plugin/detail/Factory.hh 100.00% <ø> (ø)
core/include/gz/plugin/detail/Plugin.hh 100.00% <ø> (ø)
core/include/gz/plugin/detail/PluginPtr.hh 100.00% <ø> (ø)
core/include/gz/plugin/detail/SpecializedPlugin.hh 100.00% <ø> (ø)
core/src/EnablePluginFromThis.cc 100.00% <ø> (ø)
core/src/Factory.cc 100.00% <ø> (ø)
core/src/Info.cc 100.00% <ø> (ø)
core/src/Plugin.cc 100.00% <ø> (ø)
core/src/WeakPluginPtr.cc 100.00% <ø> (ø)
core/src/utility.cc 100.00% <ø> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Aug 12, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Aug 15, 2022
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the citadel_header_redirects branch 6 times, most recently from 8b0410b to e1ef4d3 Compare August 19, 2022 03:00
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the citadel_header_redirects branch 2 times, most recently from 77d45c5 to 322c53e Compare August 19, 2022 03:47
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon changed the title ign -> gz Reverse Ignition Headers : gz-plugin ign -> gz Migrate Ignition Headers : gz-plugin Aug 22, 2022
@scpeters
Copy link
Member

I've opened #105 with a special branch name to test CI on macOS with gazebosim/gz-cmake#303

@scpeters
Copy link
Member

@osrf-jenkins run tests please

@methylDragon
Copy link
Contributor Author

methylDragon commented Sep 1, 2022

This should be good to (rebase) merge! (I just need to amend the commit messages)

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

core/include/ignition/plugin/config.hh Show resolved Hide resolved
@mjcarroll mjcarroll merged commit e86f925 into ign-plugin1 Nov 11, 2022
@mjcarroll mjcarroll deleted the citadel_header_redirects branch November 11, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants