Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include windows instructions in examples README.md and fix examples to compile them on Windows #48

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Mar 26, 2021

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Include windows instructions in examples README.md and fix examples to compile them on Windows

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde requested a review from mxgrey as a code owner March 26, 2021 18:55
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #48 (2e7f867) into ign-plugin1 (170c12f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-plugin1      #48   +/-   ##
============================================
  Coverage        99.82%   99.82%           
============================================
  Files               15       15           
  Lines              584      584           
============================================
  Hits               583      583           
  Misses               1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170c12f...2e7f867. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment.

examples/CMakeLists.txt Outdated Show resolved Hide resolved
@chapulina chapulina added documentation Improvements or additions to documentation Windows Windows support labels Mar 26, 2021
@chapulina chapulina merged commit 53f0f68 into ign-plugin1 Mar 30, 2021
@chapulina chapulina deleted the ahcorde/examples/windows branch March 30, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel documentation Improvements or additions to documentation 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants