Bumps in garden : ign-cmake3, ign-util2, ign-plugin2

[methylDragon]

See gazebo-tooling/release-tools#685

[methylDragon]

Run with command:
./bump_dependency.bash garden "ign-cmake;ign-utils;ign-plugin" "3;2;2" 685 garden

---

https://github.com/ignitionrobotics/ign-plugin/pull/74/files#diff-b171701a8039aa411e8f6a1710925af464824660092863f0ff3f4e426f89402bL259 might be an edge case, perhaps an instance of greedy matching? It doesn't look like plugin1 should have been replaced with plugin2

Also, I'm not sure ign-common5 and ign-math7 was bumped... Will it cause downstream issues?

[chapulina]

https://github.com/ignitionrobotics/ign-plugin/pull/74/files#diff-b171701a8039aa411e8f6a1710925af464824660092863f0ff3f4e426f89402bL259 might be an edge case, perhaps an instance of greedy matching?

Ouch yes, that doesn't need to change

Also, I'm not sure ign-common5 and ign-math7 was bumped... Will it cause downstream issues?

Oh that was actually the script being kinda smart! It's unusual that a library has a reference to libraries that aren't direct dependencies, which is the case of ign-math and ign-common here. But if it will refer to them, it should refer to the versions that are supported together. This shouldn't cause issues and it's a good change 👍🏽

[chapulina]

Just one extra comment besides the other issue that you already caught

[codecov]

Codecov Report

Merging #74 (bff7428) into main (940e918) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          17       17           
  Lines         616      616           
=======================================
  Hits          614      614           
  Misses          2        2           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940e918...bff7428. Read the comment docs.

[methylDragon]

@osrf-jenkins run tests please!

[chapulina]

Windows has a new warning?!

[5.063s] CMake Warning:
[5.063s]   Manually-specified variables were not used by the project:
[5.063s] 
[5.063s]     CMAKE_TOOLCHAIN_FILE

[methylDragon]

Windows has a new warning?!

[5.063s] CMake Warning:
[5.063s]   Manually-specified variables were not used by the project:
[5.063s] 
[5.063s]     CMAKE_TOOLCHAIN_FILE

It passed on my push, even though nothing changed 😬

But it does still print that CMake projects should use: "-DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake", just that no warning seems to have been emitted?

[scpeters]

Windows has a new warning?!

[5.063s] CMake Warning:
[5.063s]   Manually-specified variables were not used by the project:
[5.063s] 
[5.063s]     CMAKE_TOOLCHAIN_FILE

It passed on my push, even though nothing changed 😬

But it does still print that CMake projects should use: "-DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake", just that no warning seems to have been emitted?

the windows builds do not fail on cmake warnings because we haven't configured jenkins to check windows jobs with that parser. I think it's fine

[chapulina]

LGTM when CI comes back 🟢 ❗