Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate cli tool into libexec #80

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Relocate cli tool into libexec #80

merged 1 commit into from
Apr 29, 2022

Conversation

j-rivero
Copy link
Contributor

Summary

CLI tool should be placed into libexec instead of using the standard location for libraries.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@j-rivero
Relocate cli tool into libexec
04e3593 
Signed-off-by: Jose Luis Rivero <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 29, 2022
@j-rivero j-rivero mentioned this pull request Apr 29, 2022
Merged
@j-rivero j-rivero merged commit fd41c63 into main Apr 29, 2022
@j-rivero j-rivero deleted the jrivero/libexec_cli branch April 29, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-rivero @chapulina