Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change IGN_DESIGNATION to GZ_DESIGNATION #96

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Change IGN_DESIGNATION to GZ_DESIGNATION #96

merged 2 commits into from
Jul 23, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 20, 2022

Signed-off-by: Nate Koenig [email protected]

I ran find . -name "*" -exec -i 's/IGN_DESIGNATION/GZ_DESIGNATION/g' {} \; in order to make this repository compliant with gazebosim/gz-cmake#282

@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jul 20, 2022
@chapulina chapulina added needs upstream release Blocked by a release of an upstream library ign to gz Renaming Ignition to Gazebo. labels Jul 20, 2022
chapulina
chapulina approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't merge this until gazebosim/gz-cmake#282 is merged and released.

@scpeters scpeters mentioned this pull request Jul 22, 2022
Merged
7 tasks
@scpeters
Copy link
Member

@osrf-jenkins run tests please

@chapulina
Require gz-cmake 2.13
96d7634 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina enabled auto-merge (squash) July 23, 2022 04:32
@codecov
Copy link

codecov bot commented Jul 23, 2022 •
edited
Loading

Codecov Report

Merging #96 (96d7634) into ign-plugin1 (d12d5ad) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-plugin1      #96   +/-   ##
============================================
  Coverage        99.82%   99.82%           
============================================
  Files               15       15           
  Lines              584      584           
============================================
  Hits               583      583           
  Misses               1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12d5ad...96d7634. Read the comment docs.

@chapulina chapulina merged commit 7c1a2ff into ign-plugin1 Jul 23, 2022
@chapulina chapulina deleted the gz-designation branch July 23, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkoenig @scpeters @ahcorde @chapulina