Skip to content

Commit

Permalink
Unload rendering plugin also on Windows (#1074)
Browse files Browse the repository at this point in the history
Signed-off-by: Silvio Traversaro <[email protected]>
  • Loading branch information
traversaro authored Oct 9, 2024
1 parent 589f6f6 commit a7a7247
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/RenderEngineManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -563,14 +563,10 @@ bool RenderEngineManagerPrivate::UnloadEnginePlugin(
std::string pluginName = it->second;
this->enginePlugins.erase(it);

#ifndef _WIN32
// Unloading the plugin on windows causes tests to crash on exit
// see issue #45
if (!this->pluginLoader.ForgetLibraryOfPlugin(pluginName))
{
gzerr << "Failed to unload plugin: " << pluginName << std::endl;
}
#endif

std::lock_guard<std::recursive_mutex> lock(this->enginesMutex);
auto engineIt = this->engines.find(_engineName);
Expand Down

0 comments on commit a7a7247

Please sign in to comment.