comparison tolerance for ogre float values

Signed-off-by: Louise Poubel <[email protected]>
gazebosim · Jan 23, 2021 · cd6e89f · cd6e89f
1 parent 2e37769
commit cd6e89f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Camera_TEST.cc b/src/Camera_TEST.cc
@@ -73,7 +73,7 @@ void CameraTest::ViewProjectionMatrix(const std::string &_renderEngine)
 
   EXPECT_GT(camera->AspectRatio(), 0);
   camera->SetAspectRatio(1.7777);
-  EXPECT_DOUBLE_EQ(1.7777, camera->AspectRatio());
+  EXPECT_NEAR(1.7777, camera->AspectRatio(), 1e-6);
 
   camera->SetAntiAliasing(1u);
   EXPECT_EQ(1u, camera->AntiAliasing());

diff --git a/src/Light_TEST.cc b/src/Light_TEST.cc
@@ -75,12 +75,13 @@ void LightTest::Light(const std::string &_renderEngine)
   EXPECT_FALSE(light->CastShadows());
 
   // attenuation
+  // Checking near because Ogre stores it as float
   light->SetAttenuationConstant(0.6);
-  EXPECT_DOUBLE_EQ(0.6, light->AttenuationConstant());
+  EXPECT_NEAR(0.6, light->AttenuationConstant(), 1e-6);
   light->SetAttenuationLinear(0.2);
-  EXPECT_DOUBLE_EQ(0.2, light->AttenuationLinear());
+  EXPECT_NEAR(0.2, light->AttenuationLinear(), 1e-6);
   light->SetAttenuationQuadratic(0.01);
-  EXPECT_DOUBLE_EQ(0.01, light->AttenuationQuadratic());
+  EXPECT_NEAR(0.01, light->AttenuationQuadratic(), 1e-6);
   light->SetAttenuationRange(10);
   EXPECT_DOUBLE_EQ(10, light->AttenuationRange());
 
@@ -122,7 +123,7 @@ void LightTest::Light(const std::string &_renderEngine)
   spotLight->SetOuterAngle(math::Angle(0.2));
   EXPECT_EQ(math::Angle(0.2), spotLight->OuterAngle());
   spotLight->SetFalloff(0.2);
-  EXPECT_DOUBLE_EQ(0.2, spotLight->Falloff());
+  EXPECT_NEAR(0.2, spotLight->Falloff(), 1e-6);
 
   // remove lights
   scene->DestroyLightById(light->Id());