Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing AxisVisual and ArrowVisual implementation #85

Closed
iche033 opened this issue May 19, 2020 · 4 comments
Closed

Missing AxisVisual and ArrowVisual implementation #85

iche033 opened this issue May 19, 2020 · 4 comments
Labels
enhancement New feature or request ogre1.x ogre2.x

Comments

@iche033
Copy link
Contributor

iche033 commented May 19, 2020

Implementation of AxisVisual and ArrowVisual is missing for ogre (empty classes) and ogre2 (no implementation).
@iche033 iche033 added enhancement New feature or request ogre1.x ogre2.x labels May 19, 2020
@iche033 iche033 mentioned this issue May 19, 2020
Closed
@Levi-Armstrong
Copy link
Contributor

These methods currently work for ogre1 and ogre2 on melodic so I looked into the issue. The class is empty because it is implemented in the base class (BaseAxisVisual and BaseArrowVisual) using calls to createConeVisual and createCylinderVisual.

@iche033
Copy link
Contributor Author

iche033 commented May 20, 2020

oh I missed that. Thanks for looking into this. I think I just tested ogre2 at the time and it was not working. It's mainly missing a few hooks to return a valid pointer. Done in pull requests #87

@Levi-Armstrong
Copy link
Contributor

Thank you for the support.

@iche033
Copy link
Contributor Author

iche033 commented May 27, 2020

pull request #87

@iche033 iche033 closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ogre1.x ogre2.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iche033 @Levi-Armstrong