Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single cubemap camera in lidar #1013

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Use single cubemap camera in lidar #1013

merged 1 commit into from
Jun 28, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 28, 2024

🦟 Bug fix

Summary

Minor resource optimization in lidars. Cameras can use quite a bite of memory. Originally lidars may use up to 6 cubemap cameras (depending on FOV) for sampling depth data. This PR reduces it to just one single cube camera that just changes its orientation to face the 6 different faces of the cubemap for sampling depth data. This is similar to how lidars in the ogre 1.x implementation sample data.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jun 28, 2024
@iche033 iche033 merged commit c6c9fd5 into gz-rendering8 Jun 28, 2024
9 of 10 checks passed
@iche033 iche033 deleted the lidar_cubemap branch June 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants