Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug builds of gz-rendering-ogre2 plugin #1014

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix debug builds of gz-rendering-ogre2 plugin #1014

merged 1 commit into from
Jul 3, 2024

Commits on Jul 3, 2024

  1. Fix debug builds of gz-rendering-ogre2 plugin 

    The ogre2 plugin fails to load in gz-sim when gz-rendering
is built in Debug mode. The following error message is emitted:
```
Error while loading the library [....lib/gz-rendering-8/engine-plugins/libgz-rendering-ogre2.so]: ....lib/gz-rendering-8/engine-plugins/libgz-rendering-ogre2.so: undefined symbol: _ZThn1008_N4Ogre7HlmsPbs19_changeRenderSystemEPNS_12RenderSystemE
```

This is because we set `DEBUG=1` and `_DEBUG=1`
on the ogre2 target which seem to change the ABI of the generated
library. These defines should really be set if Ogre2 itself is built in
debug mode, so this PR simply comments out the CMake command that adds
those defines.

Signed-off-by: Addisu Z. Taddese <[email protected]>
    @azeey
    azeey committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    7ffd39a View commit details
    Browse the repository at this point in the history