Fix overriding ogre2 transparency blend mode #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
ahcorde
approved these changes
Mar 8, 2021
chapulina
approved these changes
Mar 8, 2021
Codecov Report
@@ Coverage Diff @@
## ign-rendering4 #266 +/- ##
==================================================
+ Coverage 52.59% 53.50% +0.90%
==================================================
Files 143 145 +2
Lines 13329 13753 +424
==================================================
+ Hits 7010 7358 +348
- Misses 6319 6395 +76
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Fixes gazebosim/gz-sim#496
Summary
Fixes issue with ign-gazebo's TransformControl tool being occluded by models.
The ogre2 transparency blend mode setting was being override when copying a material due to the order of the calls.
->
SetTransparency-> sets blend mode->
SetAlphaFromTexture- > overrides the blend mode set in the previous call if arg isfalseThe PR reverses the order to make sure we keep the blend mode if visual is semi-transparent
Also made sure that if
SetAlphaFromTexture(false)is called any time afterwards, we don't change the existing blend mode.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge