🎈 5.1.0 #351
Merged
🎈 5.1.0 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering5 #351 +/- ##
===============================================
Coverage 57.80% 57.80%
===============================================
Files 161 161
Lines 15851 15851
===============================================
Hits 9162 9162
Misses 6689 6689 Continue to review full report at Codecov.
|
jennuine
approved these changes
Jun 23, 2021
iche033
approved these changes
Jun 23, 2021
darksylinc
pushed a commit
to darksylinc/ign-rendering
that referenced
this pull request
Jul 17, 2021
Signed-off-by: Louise Poubel <[email protected]>
iche033
pushed a commit
that referenced
this pull request
Jul 19, 2021
* 🎈 5.1.0 (#351) Signed-off-by: Louise Poubel <[email protected]> * Replace renderOneFrame for per-workspace update calls Add Scene::PostRenderGpuFlush Breaks ABI. Needs changes to other components as well, so they call Scene::PostRenderGpuFlush Affects #323 Signed-off-by: Matias N. Goldberg <[email protected]> * Add Scene::SetLegacyAutoGpuFlush Affects #323 Signed-off-by: Matias N. Goldberg <[email protected]> * Add Scene::SetNumCameraPassesPerGpuFlush Renamed PostRenderGpuFlush to PostRender PostRenderGpuFlush was leaking too much internal behavior of how the engine works into the user. The new way of forcing the user to pair PreRender and PostRender calls is much easier to understand and user-friendly Signed-off-by: Matias N. Goldberg <[email protected]> * Assert when PreRender/PostRender calls are used incorrectly Signed-off-by: Matias N. Goldberg <[email protected]> * Fix warnings generated by gazebo in legacy mode Signed-off-by: Matias N. Goldberg <[email protected]> * Add missing listener triggers Fixes GpuRays/GpuRaysTest.RaysParticles failure Particle FXs should now be working as intended Signed-off-by: Matias N. Goldberg <[email protected]> * Rename functions to be consistent w/ Ignition naming convention SetNumCameraPassesPerGpuFlush -> SetCameraPassCountPerGpuFlush GetNumCameraPassesPerGpuFlush -> GetCameraPassCountPerGpuFlush GetLegacyAutoGpuFlush -> LegacyAutoGpuFlush Signed-off-by: Matias N. Goldberg <[email protected]> * Document that SetCameraPassCountPerGpuFlush is an upper bound Signed-off-by: Matias N. Goldberg <[email protected]> * Document Camera::Update shouldn't be called if there's many cameras Signed-off-by: Matias N. Goldberg <[email protected]> * Check in Render() call that we're inside PreRender / PostRender Signed-off-by: Matias N. Goldberg <[email protected]> * Fix INTEGRATION_camera crash Signed-off-by: Matias N. Goldberg <[email protected]> * Fix EndFrame not getting called when in non-legacy mode INTEGRATION_depth_camera now succeeds Signed-off-by: Matias N. Goldberg <[email protected]> * Fix wrong documentation about Camera::Capture Signed-off-by: Matias N. Goldberg <[email protected]> * Update Migration notes w/ Scene::PostRender Signed-off-by: Matias N. Goldberg <[email protected]> * Add missing call in doc's recomendations Signed-off-by: Matias N. Goldberg <[email protected]> * Improve documentation and make asserts more helpful Signed-off-by: Matias N. Goldberg <[email protected]> * Default cameraPassCountPerGpuFlush until all modules are merged Fix wrong documentation about currNumCameraPasses Signed-off-by: Matias N. Goldberg <[email protected]> * Remove unnecessary headers Signed-off-by: Matias N. Goldberg <[email protected]> * Style changes for consistency with the rest of the codebase Better document code in FlushGpuCommandsOnly Signed-off-by: Matias N. Goldberg <[email protected]> * Multiple fixes - Do not recommend the user to call Camera::PreRender in docs. This is done implicitly via Scene::PreRender - Rename GetCameraPassCountPerGpuFlush -> CameraPassCountPerGpuFlush - CameraPassCountPerGpuFlush was incorrectly always returning 0 - Grammar mistakes in comments Signed-off-by: Matias N. Goldberg <[email protected]> * Make cameraPassCountPerGpuFlush default to 6 Signed-off-by: Matias N. Goldberg <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
WilliamLewww
pushed a commit
to WilliamLewww/ign-rendering
that referenced
this pull request
Dec 7, 2021
* 🎈 5.1.0 (gazebosim#351) Signed-off-by: Louise Poubel <[email protected]> * Replace renderOneFrame for per-workspace update calls Add Scene::PostRenderGpuFlush Breaks ABI. Needs changes to other components as well, so they call Scene::PostRenderGpuFlush Affects gazebosim#323 Signed-off-by: Matias N. Goldberg <[email protected]> * Add Scene::SetLegacyAutoGpuFlush Affects gazebosim#323 Signed-off-by: Matias N. Goldberg <[email protected]> * Add Scene::SetNumCameraPassesPerGpuFlush Renamed PostRenderGpuFlush to PostRender PostRenderGpuFlush was leaking too much internal behavior of how the engine works into the user. The new way of forcing the user to pair PreRender and PostRender calls is much easier to understand and user-friendly Signed-off-by: Matias N. Goldberg <[email protected]> * Assert when PreRender/PostRender calls are used incorrectly Signed-off-by: Matias N. Goldberg <[email protected]> * Fix warnings generated by gazebo in legacy mode Signed-off-by: Matias N. Goldberg <[email protected]> * Add missing listener triggers Fixes GpuRays/GpuRaysTest.RaysParticles failure Particle FXs should now be working as intended Signed-off-by: Matias N. Goldberg <[email protected]> * Rename functions to be consistent w/ Ignition naming convention SetNumCameraPassesPerGpuFlush -> SetCameraPassCountPerGpuFlush GetNumCameraPassesPerGpuFlush -> GetCameraPassCountPerGpuFlush GetLegacyAutoGpuFlush -> LegacyAutoGpuFlush Signed-off-by: Matias N. Goldberg <[email protected]> * Document that SetCameraPassCountPerGpuFlush is an upper bound Signed-off-by: Matias N. Goldberg <[email protected]> * Document Camera::Update shouldn't be called if there's many cameras Signed-off-by: Matias N. Goldberg <[email protected]> * Check in Render() call that we're inside PreRender / PostRender Signed-off-by: Matias N. Goldberg <[email protected]> * Fix INTEGRATION_camera crash Signed-off-by: Matias N. Goldberg <[email protected]> * Fix EndFrame not getting called when in non-legacy mode INTEGRATION_depth_camera now succeeds Signed-off-by: Matias N. Goldberg <[email protected]> * Fix wrong documentation about Camera::Capture Signed-off-by: Matias N. Goldberg <[email protected]> * Update Migration notes w/ Scene::PostRender Signed-off-by: Matias N. Goldberg <[email protected]> * Add missing call in doc's recomendations Signed-off-by: Matias N. Goldberg <[email protected]> * Improve documentation and make asserts more helpful Signed-off-by: Matias N. Goldberg <[email protected]> * Default cameraPassCountPerGpuFlush until all modules are merged Fix wrong documentation about currNumCameraPasses Signed-off-by: Matias N. Goldberg <[email protected]> * Remove unnecessary headers Signed-off-by: Matias N. Goldberg <[email protected]> * Style changes for consistency with the rest of the codebase Better document code in FlushGpuCommandsOnly Signed-off-by: Matias N. Goldberg <[email protected]> * Multiple fixes - Do not recommend the user to call Camera::PreRender in docs. This is done implicitly via Scene::PreRender - Rename GetCameraPassCountPerGpuFlush -> CameraPassCountPerGpuFlush - CameraPassCountPerGpuFlush was incorrectly always returning 0 - Grammar mistakes in comments Signed-off-by: Matias N. Goldberg <[email protected]> * Make cameraPassCountPerGpuFlush default to 6 Signed-off-by: Matias N. Goldberg <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Signed-off-by: William Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎈 Release
Preparation for 5.1.0 release.
Comparison to 5.0.0: ignition-rendering5_5.0.0...ign-rendering5
Needed by gazebosim/gz-gui#238
Checklist
Note to maintainers: Remember to use Squash-Merge