Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple_demo_qml coding style #404

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 13, 2021

🦟 Bug fix

A follow up to #373

Made a few coding style changes to be consistent with rest of Ignition code base as mentioned in this comment

2 space indentation
wrap line to 80 chars
use .hh and .cc file extensions
function separator style: //////////////////////////////////////////////////

see 2c7ac93 for the coding style changes before renaming the files.

I didn't touch ThreadedRenderer[.h|.cpp] as the code is mostly adapted from a Qt demo.

The only non-style change I made is adding these two lines below to set the env variable as mentioned in this comment

    // use single-threaded scene graph rendering
    qputenv("QSG_RENDER_LOOP", "basic");

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #404 (ca0a3bf) into ign-rendering5 (49e7a06) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ca0a3bf differs from pull request most recent head ad17f2e. Consider uploading reports for the commit ad17f2e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering5     #404   +/-   ##
===============================================
  Coverage           57.77%   57.77%           
===============================================
  Files                 161      161           
  Lines               15947    15947           
===============================================
+ Hits                 9213     9214    +1     
+ Misses               6734     6733    -1     
Impacted Files Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e7a06...ad17f2e. Read the comment docs.

@iche033 iche033 merged commit f83dc91 into ign-rendering5 Sep 14, 2021
@iche033 iche033 deleted the simple_demo_qml_style branch September 14, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants