Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Heightmap tutorial image #431

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Update Heightmap tutorial image #431

merged 2 commits into from
Sep 27, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 24, 2021

🦟 Bug fix

Summary

Update image to show the heightmap demo rendered in ogre2

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #431 (df70b89) into main (e465a98) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   55.11%   55.11%           
=======================================
  Files         192      192           
  Lines       19383    19383           
=======================================
  Hits        10682    10682           
  Misses       8701     8701           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e465a98...df70b89. Read the comment docs.

@chapulina chapulina added beta Targeting beta release of upcoming collection documentation Improvements or additions to documentation labels Sep 27, 2021
@chapulina chapulina merged commit 5c7f216 into main Sep 27, 2021
@chapulina chapulina deleted the heightmap_tut_img branch September 27, 2021 17:58
WilliamLewww pushed a commit to WilliamLewww/ign-rendering that referenced this pull request Dec 7, 2021
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection documentation Improvements or additions to documentation 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants