Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix point cloud material syntax error #433

Merged
merged 4 commits into from
Oct 7, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 24, 2021

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Without this fix, you would see an entry in ~/.ignition/rendering/ogre2.log:

Compiler error: invalid parameters in point_cloud_point.material(34): incorrect type specified; only variants of int, uint, float, double, and bool allowed

Point cloud visualization still worked though. It could be just that the initial values are not set correctly.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #433 (60ef35d) into main (34d1d0a) will increase coverage by 0.03%.
The diff coverage is 81.81%.

❗ Current head 60ef35d differs from pull request most recent head 2707f18. Consider uploading reports for the commit 2707f18 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   53.46%   53.49%   +0.03%     
==========================================
  Files         192      192              
  Lines       19536    19560      +24     
==========================================
+ Hits        10444    10464      +20     
- Misses       9092     9096       +4     
Impacted Files Coverage Δ
ogre2/src/Ogre2Heightmap.cc 0.00% <ø> (ø)
ogre2/src/Ogre2SegmentationMaterialSwitcher.cc 61.22% <40.00%> (-1.55%) ⬇️
ogre2/src/Ogre2RenderEngine.cc 79.56% <60.00%> (-0.25%) ⬇️
ogre2/src/Ogre2DepthCamera.cc 87.30% <100.00%> (+0.17%) ⬆️
ogre2/src/Ogre2RayQuery.cc 38.70% <100.00%> (-0.69%) ⬇️
ogre2/src/Ogre2RenderTarget.cc 86.05% <100.00%> (+0.20%) ⬆️
ogre2/src/Ogre2Scene.cc 74.34% <100.00%> (+0.08%) ⬆️
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d1d0a...2707f18. Read the comment docs.

@iche033 iche033 changed the base branch from main to ign-rendering6 October 7, 2021 06:21
@iche033 iche033 merged commit 67b5420 into ign-rendering6 Oct 7, 2021
@iche033 iche033 deleted the point_cloud_mat_syntax branch October 7, 2021 18:20
srmainwaring pushed a commit to srmainwaring/gz-rendering that referenced this pull request Oct 21, 2021
Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
WilliamLewww pushed a commit to WilliamLewww/ign-rendering that referenced this pull request Dec 7, 2021
Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants