-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix point cloud material syntax error #433
Conversation
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 53.46% 53.49% +0.03%
==========================================
Files 192 192
Lines 19536 19560 +24
==========================================
+ Hits 10444 10464 +20
- Misses 9092 9096 +4
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: William Lew <[email protected]>
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Summary
Without this fix, you would see an entry in
~/.ignition/rendering/ogre2.log
:Point cloud visualization still worked though. It could be just that the initial values are not set correctly.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge