Fix occasional flickering issue when skybox and directional light shadows are enabled. #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #440 +/- ##
==========================================
+ Coverage 53.46% 53.49% +0.03%
==========================================
Files 192 192
Lines 19536 19549 +13
==========================================
+ Hits 10444 10458 +14
+ Misses 9092 9091 -1
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Sep 29, 2021
chapulina
added
beta
Signed-off-by: Ian Chen <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
When both skybox and shadows are enabled in a complex scene (with lots of textures), there seem to be a weird "flickering" issue of objects. Turns out the problem is due to the skybox being rendered out of order. The skybox texture just gets rendered over the scene - so objects look like they are flickering.
Note this doesn't happen all the time. It's easier to reproduce on some machines than others.
The updated compositor setup follows the same setup in ogre samples:
https://github.com/OGRECave/ogre-next/blob/v2-2/Samples/Media/2.0/scripts/Compositors/TutorialSky_Postprocess.compositor#L8-L32
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge