Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide heightmaps in segmentation camera #443

Merged
merged 5 commits into from
Sep 30, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 30, 2021

🦟 Bug fix

Alternative to #441

Summary

Disable heightmaps in segmentation camera until we can label it by setting its material

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI comes back green. Thanks!

ogre2/src/Ogre2SegmentationMaterialSwitcher.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #443 (700f37b) into main (eb7d6ea) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 700f37b differs from pull request most recent head 063eccc. Consider uploading reports for the commit 063eccc to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #443   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files         192      192           
  Lines       19554    19566   +12     
=======================================
+ Hits        10460    10467    +7     
- Misses       9094     9099    +5     
Impacted Files Coverage Δ
ogre2/src/Ogre2Heightmap.cc 0.00% <ø> (ø)
ogre2/src/Ogre2SegmentationMaterialSwitcher.cc 61.22% <40.00%> (-1.55%) ⬇️
ogre2/src/Ogre2Scene.cc 74.34% <100.00%> (+0.08%) ⬆️
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7d6ea...063eccc. Read the comment docs.

@chapulina chapulina added beta Targeting beta release of upcoming collection bug Something isn't working labels Sep 30, 2021
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 merged commit 084516a into main Sep 30, 2021
@iche033 iche033 deleted the iche033/heightmap_segmentation_patch branch September 30, 2021 20:59
@iche033 iche033 mentioned this pull request Sep 30, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants