ogre: Add missing required Paging component #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvio <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering5 #452 +/- ##
===============================================
Coverage 56.07% 56.08%
===============================================
Files 161 161
Lines 16085 16085
===============================================
+ Hits 9020 9021 +1
+ Misses 7065 7064 -1
Continue to review full report at Codecov.
|
chapulina
added a commit
that referenced
this pull request
Oct 18, 2021
* Fix ray query distance calculation (#438) * fix ray query dist calc Signed-off-by: Ian Chen <[email protected]> * disable test Signed-off-by: Ian Chen <[email protected]> * ogre: Add missing required Paging component (#452) Signed-off-by: Silvio <[email protected]> * Fix selection buffer material script (#456) Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Silvio Traversaro <[email protected]>
srmainwaring
pushed a commit
to srmainwaring/gz-rendering
that referenced
this pull request
Oct 21, 2021
Signed-off-by: Silvio <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Add the missing dependency on
PagingOgre component for theogrerenderer. See https://github.com/ignitionrobotics/ign-rendering/blob/ign-rendering5/ogre/include/ignition/rendering/ogre/OgreIncludes.hh#L66 for a Paging-related include that is required.Summary
I noticed this missing component while working on conda-forge/libignition-rendering4-feedstock#19 (comment) . Not sure if that failure was just related to this fix, but given that this fix seems to be correct in any case, I tought it could make sense to submit it.
Checklist
codecheckpassed (See contributing)