Fix context attributes of glXCreateContextAttribsARB. #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ign-rendering5 #460 +/- ##
==================================================
- Coverage 57.80% 56.08% -1.72%
==================================================
Files 161 161
Lines 16086 16085 -1
==================================================
- Hits 9298 9021 -277
- Misses 6788 7064 +276
Continue to review full report at Codecov.
|
Signed-off-by: Hill Ma <[email protected]>
chapulina
approved these changes
Oct 15, 2021
iche033
approved these changes
Oct 19, 2021
iche033
added a commit
that referenced
this pull request
Oct 19, 2021
* ogre: Do not assume that ogre plugins have lib prefix on macOS (#454) Signed-off-by: Silvio <[email protected]> * Fix compilation against Ogre 1.10.12 (#390) Signed-off-by: GitHub <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> * Avoid symbol redefition to fix armel builds (#457) * Avoid symbol redefiniition on armel builds Signed-off-by: Jose Luis Rivero <[email protected]> * Fix logic on warning for ogre versions different than 1.9.x (#465) * Fix logic on warning for ogre versions different than 1.9.x Signed-off-by: Jose Luis Rivero <[email protected]> * Fix context attributes of glXCreateContextAttribsARB. (#460) Signed-off-by: Hill Ma <[email protected]> Co-authored-by: Silvio Traversaro <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Jose Luis Rivero <[email protected]> Co-authored-by: Hill Ma <[email protected]>
srmainwaring
pushed a commit
to srmainwaring/gz-rendering
that referenced
this pull request
Oct 21, 2021
Signed-off-by: Hill Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should've read the spec more carefully in the previous PR ...