Backport wave changes

[iche033]

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Backport some minor changes from #555:

• removed unused variable
• fixed variable names
• adjusted wave amplitude and camera z pos

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #557 (1cc1a72) into ign-rendering6 (1258280) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           ign-rendering6     #557      +/-   ##
==================================================
- Coverage           54.38%   54.38%   -0.01%     
==================================================
  Files                 198      198              
  Lines               20147    20147              
==================================================
- Hits                10957    10956       -1     
- Misses               9190     9191       +1     

Impacted Files	Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh	96.66% <0.00%> (-3.34%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1258280...1cc1a72. Read the comment docs.

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1