Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #563 #570

Conversation

WilliamLewww
Copy link
Contributor

Signed-off-by: William Lew [email protected]

➡️ Backport #563

This backports a OgreRTShaderSystem segfault fix main to ign-rendering6.

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Signed-off-by: William Lew <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #570 (a4b5075) into ign-rendering6 (a6170b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering6     #570   +/-   ##
===============================================
  Coverage           54.37%   54.37%           
===============================================
  Files                 198      198           
  Lines               20149    20151    +2     
===============================================
+ Hits                10956    10958    +2     
  Misses               9193     9193           
Impacted Files Coverage Δ
ogre/src/OgreRTShaderSystem.cc 43.54% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6170b1...a4b5075. Read the comment docs.

@iche033 iche033 merged commit 9ad2a50 into gazebosim:ign-rendering6 Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants