Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Fixed Readme.md typo #620

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

Gjacquenot
Copy link
Contributor

@Gjacquenot Gjacquenot commented May 5, 2022

🦟 Bug fix

Fixes #619

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Gjacquenot Gjacquenot requested a review from iche033 as a code owner May 5, 2022 19:56
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 5, 2022
@ahcorde
Copy link
Contributor

ahcorde commented May 5, 2022

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #620 (bf4c659) into ign-rendering6 (abbe5d2) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-rendering6     #620   +/-   ##
===============================================
  Coverage           80.00%   80.00%           
===============================================
  Files                   1        1           
  Lines                  15       15           
===============================================
  Hits                   12       12           
  Misses                  3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abbe5d2...bf4c659. Read the comment docs.

@chapulina chapulina added the documentation Improvements or additions to documentation label May 5, 2022
Signed-off-by: Guillaume Jacquenot <[email protected]>
@Gjacquenot
Copy link
Contributor Author

do you mind to sign the commit ? https://github.com/ignitionrobotics/ign-rendering/pull/620/checks?check_run_id=6312811553

Sorry for the delay, I have added the signature. Since I made the commit from the web browser, I thought the GitHub signature was equivalent...

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #620 (6760b2c) into ign-rendering6 (e4c9157) will not change coverage.
The diff coverage is n/a.

❗ Current head 6760b2c differs from pull request most recent head 6956c6a. Consider uploading reports for the commit 6956c6a to get more accurate results

@@               Coverage Diff               @@
##           ign-rendering6     #620   +/-   ##
===============================================
  Coverage           80.00%   80.00%           
===============================================
  Files                   1        1           
  Lines                  15       15           
===============================================
  Hits                   12       12           
  Misses                  3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c9157...6956c6a. Read the comment docs.

@ahcorde ahcorde enabled auto-merge (squash) May 9, 2022 10:19
@ahcorde ahcorde merged commit 585f4f6 into gazebosim:ign-rendering6 May 9, 2022
@Gjacquenot Gjacquenot deleted the patch-1 branch May 9, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in main Readme.md
4 participants