Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport multiple ray queries fix (#665) #690

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 27, 2022

Signed-off-by: Ian Chen [email protected]
Signed-off-by: Michel Hidalgo [email protected]

🦟 Bug fix

Backport #665 by cherry picking commit 8d7e008

Summary

Fixes issue with using ray queries from multiple cameras.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #690 (80e10b0) into ign-rendering6 (d3a8e8c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           ign-rendering6     #690   +/-   ##
===============================================
  Coverage           54.58%   54.59%           
===============================================
  Files                 202      202           
  Lines               21106    21109    +3     
===============================================
+ Hits                11521    11524    +3     
  Misses               9585     9585           
Impacted Files Coverage Δ
ogre2/src/Ogre2SelectionBuffer.cc 93.06% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a8e8c...80e10b0. Read the comment docs.

@iche033 iche033 added the mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/ label Jul 28, 2022
@ahcorde ahcorde merged commit 88a8b62 into ign-rendering6 Jul 28, 2022
@ahcorde ahcorde deleted the backport_multiple_rayqueries branch July 28, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants