Added a method to show the head on arrows and axis #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
======================================
Coverage 7.56% 7.56%
======================================
Files 26 26
Lines 1744 1744
======================================
Hits 132 132
Misses 1612 1612 Continue to review full report at Codecov.
|
iche033
requested changes
Jun 3, 2020
| template <class T> | ||
| void BaseAxisVisual<T>::ShowAxisHead(bool b) | ||
| { | ||
| for (unsigned int i = 0; i < this->ChildCount(); ++i) { |
There was a problem hiding this comment.
style nitpick, { on new line
there is also a minor codecheck error here:
https://build.osrfoundation.org/job/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/629/cppcheckResult/
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
iche033
approved these changes
Jun 4, 2020
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
chapulina
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the PR gazebosim/gz-sim#150 it makes sense to show only the line of the arrow. These methods allow to hidde the head of the arrow and axis.
Signed-off-by: ahcorde [email protected]